Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument checks in env plugin #988

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR fixes a small oversight in the env plugin.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (bdfc048) to head (39ab6dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/other/env.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   77.73%   77.72%   -0.01%     
==========================================
  Files         326      326              
  Lines       28573    28575       +2     
==========================================
  Hits        22210    22210              
- Misses       6363     6365       +2     
Flag Coverage Δ
unittests 77.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic merged commit 3df28eb into fox-it:main Jan 14, 2025
16 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/env-plugin-arg branch January 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants