Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kape VHDX loader #993

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Add Kape VHDX loader #993

merged 7 commits into from
Jan 30, 2025

Conversation

qmadev
Copy link
Contributor

@qmadev qmadev commented Jan 16, 2025

This PR adds a new loader to map a Kape VHDX file to a Target. The previous implementation only worked on directories created by Kape, but there is also an option to store the collected data in a VHDX file.

Never wrote a loader before so I'm not sure if this is the way to go.

@Schamper
Copy link
Member

Thanks for the contribution! I've not looked at the Kape VHDX format myself yet, but how similar is the directory structure to that of a Kape "directory"? If it matches, the logic could be simplified and re-use the existing Kape directory loading code. (Loaders and the directory filesystem also work on TargetPath objects, paths that come from within a Dissect opened filesystem)

@qmadev
Copy link
Contributor Author

qmadev commented Jan 30, 2025

Thanks for the tip! The directory structure is the same so I changed the code to use a TargetPath object.

@qmadev qmadev requested a review from Schamper January 30, 2025 15:10
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (385512c) to head (809e193).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/loaders/kape.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   77.77%   77.93%   +0.15%     
==========================================
  Files         327      327              
  Lines       28659    28677      +18     
==========================================
+ Hits        22290    22349      +59     
+ Misses       6369     6328      -41     
Flag Coverage Δ
unittests 77.93% <92.59%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit ca216f4 into fox-it:main Jan 30, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants