-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kape VHDX loader #993
Add Kape VHDX loader #993
Conversation
Thanks for the contribution! I've not looked at the Kape VHDX format myself yet, but how similar is the directory structure to that of a Kape "directory"? If it matches, the logic could be simplified and re-use the existing Kape directory loading code. (Loaders and the directory filesystem also work on |
Thanks for the tip! The directory structure is the same so I changed the code to use a |
…target into feature/kape-vhdx-loader
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
+ Coverage 77.77% 77.93% +0.15%
==========================================
Files 327 327
Lines 28659 28677 +18
==========================================
+ Hits 22290 22349 +59
+ Misses 6369 6328 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR adds a new loader to map a Kape VHDX file to a
Target
. The previous implementation only worked on directories created by Kape, but there is also an option to store the collected data in a VHDX file.Never wrote a loader before so I'm not sure if this is the way to go.