Change linter to Ruff #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 76.70% 76.86% +0.15%
==========================================
Files 29 29
Lines 2365 2377 +12
==========================================
+ Hits 1814 1827 +13
+ Misses 551 550 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Horofic
requested changes
Jan 24, 2025
Comment on lines
315
to
316
| # if descriptor: | ||
| # import ipdb; ipdb.set_trace() |
There was a problem hiding this comment.
Suggested change
| # if descriptor: | |
| # import ipdb; ipdb.set_trace() |
|
|
||
| ipdb.set_trace() | ||
| raise Exception() | ||
| raise ValueError("Error reading block") | ||
|
|
||
| if descriptor and active_store is self and (descriptor.is_overlay or descriptor.overlay): | ||
| # print("overlaying data") |
There was a problem hiding this comment.
Suggested change
| # print("overlaying data") |
There was a problem hiding this comment.
Possibly, also the commented code below on line 371
There was a problem hiding this comment.
I left the rest as it was since this file is still a WIP 😉 those are hints for whoever continues on it.
Horofic
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43