Introduce pollingInterval to JMS consumers #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
faustin0
approved these changes
May 27, 2021
There was a problem hiding this comment.
Hi @danslapman, sorry for the delay. Nice work, looks good to me too 👍🏻
For the backport into 0.0.x series we have to set-up a proper CI and release of the artifact from a separate branch, i'll have a look into this and let you know
|
@faustin0 thank You! |
r-tomassetti
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves problem of high idle CPU consumption by adding pollingInterval to consumer loop. If this PR is fine, I will also open a backport PR into 0.0.x series, since I highly interested in CE2-compatible artifact