hygienic references to library functions in pattern compilation (fix l…

…inks-lang#24) (links-lang#843)

* hygienic references to library functions in pattern compilation

* removed commented out dead code

core/compilePatterns.ml

@@ -183,31 +183,26 @@ sig
 end
   =
 struct
-  (* let lookup_type var (_nenv, tenv, _eff) = *)
-  (*   TEnv.lookup tenv var *)
-
-  let lookup_name name (nenv, _tenv, _eff) =
-    NEnv.find name nenv
 
   let lookup_effects (_nenv, _tenv, eff) = eff
 
-  let nil env t : value =
-    TApp (Variable (lookup_name "Nil" env),
+  let nil _env t : value =
+    TApp (Variable (NEnv.find "Nil" Lib.nenv),
            [`Type t])
 
   let list_head env t : value -> tail_computation = fun v ->
     let eff = lookup_effects env in
       Apply
         (TApp
-           (Variable (lookup_name "hd" env),
+           (Variable (NEnv.find "hd" Lib.nenv),
             [`Type t; `Row eff]),
          [v])
 
   let list_tail env t : value -> tail_computation = fun v ->
     let eff = lookup_effects env in
       Apply
         (TApp
-           (Variable (lookup_name "tl" env),
+           (Variable (NEnv.find "tl" Lib.nenv),
             [`Type t; `Row eff]),
          [v])
 end
@@ -219,19 +214,14 @@ sig
 end
   =
 struct
-  (* let lookup_type var (_nenv, tenv, _eff) = *)
-  (*   TEnv.lookup tenv var *)
-
-  let lookup_name name (nenv, _tenv, _eff) =
-    NEnv.find name nenv
 
   let lookup_effects (_nenv, _tenv, eff) = eff
 
   let eq env t : value -> value -> value = fun v1 v2 ->
     let eff = lookup_effects env in
       ApplyPure
         (TApp
-           (Variable (lookup_name "==" env),
+           (Variable (NEnv.find "==" Lib.nenv),
             [`Type t; `Row eff]),
          [v1; v2])
 end

tests/collections.tests

@@ -107,7 +107,6 @@ stdout : 2 : Int
 Case patterns (with redefined hd)
 { fun hd(_) { 1 } switch (['a']) { case [y] -> y }}
 stdout : 'a' : Char
-ignore : Known hygiene problem
 
 With parentheses:
 switch ([1]) { case (x::xs) -> 1  case x -> 2 }