Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Checkbox margin when label is not defined #450

Closed
JanHamara opened this issue May 23, 2024 · 1 comment · Fixed by #515
Closed

Remove Checkbox margin when label is not defined #450

JanHamara opened this issue May 23, 2024 · 1 comment · Fixed by #515
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@JanHamara
Copy link
Contributor

  • @freenow/wave version: 1.34.4

What

Remove Checkbox margin when label is not defined, so that it is correctly aligned when used in UI with other form elements (but without labels)

Screenshot 2024-05-23 at 11 53 56

Reproduction

You can check this issue on registration drafts form on DMT
@JanHamara JanHamara added enhancement New feature or request good first issue Good for newcomers labels May 23, 2024
kabarchonok pushed a commit to kabarchonok/wave that referenced this issue Feb 4, 2025
fix: improve spaces when label is not defined (freenowtech#450)
14850e9 
The margin has been removed in favour of gap to get rid of unnecessary indentation when label undefined
@kabarchonok kabarchonok mentioned this issue Feb 4, 2025
Merged
kabarchonok added a commit to kabarchonok/wave that referenced this issue Feb 4, 2025
@kabarchonok
fix: improve spaces when label is not defined (freenowtech#450)
d4577ab 
The margin has been removed in favour of gap to get rid of unnecessary indentation when label undefined
lloydaf pushed a commit that referenced this issue Mar 11, 2025
@kabarchonok
fix: improve spaces when label is not defined (#450) (#515)
47ac450 
* fix: improve spaces when label is not defined (#450)

The margin has been removed in favour of gap to get rid of unnecessary indentation when label undefined

* chore: add shorthand margin
github-actions bot pushed a commit that referenced this issue Mar 11, 2025
@semantic-release-bot
chore(release): 2.27.1 [skip ci]
4c5c2ac 
### [2.27.1](v2.27.0...v2.27.1) (2025-03-11)

### Bug Fixes

* improve spaces when label is not defined ([#450](#450)) ([#515](#515)) ([47ac450](47ac450))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve spaces when label is not defined (#450) kabarchonok/wave
1 participant
@JanHamara