This repository was archived by the owner on Dec 11, 2020. It is now read-only.
+1 SWIFT/BIC payment type #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,8 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.3" | |||
| "php": ">=5.3.3", | |||
| "icomefromthenet/reverse-regex": "v0.0.6.2" | |||
There was a problem hiding this comment.
Great tool! I didn't know it. If you want my opinion, this deserves a dedicated regexp() formatter in the Base Provider - there will be more applications for this.
There was a problem hiding this comment.
As a side note, since parsing regexp may be slow, it might be a good idea to implement a cache (only one Parser instance per regexp string).
There was a problem hiding this comment.
Note that Faker now has its own regex-based generator (see #453), that you must use for your formatter.
Closed
|
new PR to come, using the new Faker's Regex-based generator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introducing a way to fake data using regex.