-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix axes with equal sign houses #138
Merged
g-battaglia
merged 12 commits into
g-battaglia:dev/axes-as-KerykeionPointModel
from
fkostadinov:fix_axes_with_equal_sign_houses
Jan 7, 2025
Merged
Fix axes with equal sign houses #138
g-battaglia
merged 12 commits into
g-battaglia:dev/axes-as-KerykeionPointModel
from
fkostadinov:fix_axes_with_equal_sign_houses
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix added explicit calculation of Asc/Dsc and MC/IC axes. This is required for whole-sign house systems. In whole-sign house systems the axes do usually not coincide with the house axes h1/h7 and h4/h10. Rules are:
To get this working, many changes were necessary.
What is still open is to fix tests/charts/test_charts.py. I am lacking info the intended structure of the SVGs, so it's hard to fully grasp what's going on there. My impression is that currently the issues in the test cases are not arising anymore from my changes, but from the fact that new "correct" SVG files first need to be created that can then be used as a reference for the test cases to test against. I might be wrong about that, though. Also, I don't know exactly how the creation of charts looks visually due to the same problem here, maybe some more work is needed, or maybe not, I cannot tell. A reference to more documentation would be helpful for me and others, I'd guess.