Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PointerManager raycast bug #1779

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

Starting from the last camera of the last scene.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 20, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added Bug Something isn't working Input Input related functions labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (c26f42c) 65.04% compared to head (4228a18) 65.09%.
Report is 4 commits behind head on main.

❗ Current head 4228a18 differs from pull request most recent head c48f47b. Consider uploading reports for the commit c48f47b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
+ Coverage   65.04%   65.09%   +0.04%     
==========================================
  Files         473      473              
  Lines       23641    23641              
  Branches     3362     3362              
==========================================
+ Hits        15378    15388      +10     
+ Misses       7057     7051       -6     
+ Partials     1206     1202       -4     
Files Changed Coverage Δ
packages/core/src/ComponentsManager.ts 80.86% <100.00%> (ø)
packages/core/src/input/pointer/PointerManager.ts 92.34% <100.00%> (ø)
packages/shader-lab/src/RuntimeContext.ts 83.43% <100.00%> (+0.59%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jtabibito jtabibito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 changed the title Fix code error in pointermanager._pointerRayCast Fix PointerManager raycast bug Sep 20, 2023
@GuoLei1990 GuoLei1990 merged commit fb0ee44 into galacean:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Input Input related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants