Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project loader should not use cache #1783

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Sep 20, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@gz65555 gz65555 requested a review from GuoLei1990 September 20, 2023 09:47
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (48e3f40) 65.10% compared to head (29f6c20) 65.06%.
Report is 1 commits behind head on main.

❗ Current head 29f6c20 differs from pull request most recent head 8d08afc. Consider uploading reports for the commit 8d08afc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   65.10%   65.06%   -0.04%     
==========================================
  Files         473      473              
  Lines       23641    23641              
  Branches     3362     3362              
==========================================
- Hits        15391    15382       -9     
- Misses       7048     7052       +4     
- Partials     1202     1207       +5     
Files Changed Coverage Δ
packages/loader/src/ProjectLoader.ts 30.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Sep 20, 2023
@GuoLei1990 GuoLei1990 merged commit 129e06e into galacean:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants