Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate correct types for Dataset source transformations on backend. #19666

Conversation

jmchilton
Copy link
Member

This should cleanup vue-tsc errors generated because of the unknown action types in dataset sources.

I think someone used the groomer messages I wrote for various datatypes to use an enum when defining the datatype_ext field on the frontend (the stub in api/index.ts this is replacing) - but I don't think that is appropriate. Galaxy deployers can deploy custom datatypes and custom groomers - so I think a string is a more appropriate type (we have enough references to datatype extensions that some sort of string alias would make sense potentially, but not this enum IMO). The enumeration was groomers we had nice little messages for - not the realm of what is or should be possible.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the api_typing_dataset_source_transform_actions branch 2 times, most recently from 03776d2 to 4be7c66 Compare February 20, 2025 18:56
@jmchilton jmchilton force-pushed the api_typing_dataset_source_transform_actions branch from 4be7c66 to 862e43a Compare February 21, 2025 15:44
@jmchilton jmchilton force-pushed the api_typing_dataset_source_transform_actions branch from 9d1846a to d3f48d5 Compare February 21, 2025 18:48
@jmchilton jmchilton marked this pull request as ready for review February 21, 2025 23:14
@github-actions github-actions bot added this to the 25.0 milestone Feb 21, 2025
@jmchilton jmchilton force-pushed the api_typing_dataset_source_transform_actions branch from d3f48d5 to ca84e7a Compare February 22, 2025 15:47
@jmchilton jmchilton marked this pull request as draft February 24, 2025 18:59
@jmchilton jmchilton force-pushed the api_typing_dataset_source_transform_actions branch from ca84e7a to 099f0e2 Compare February 24, 2025 22:06
@jmchilton jmchilton marked this pull request as ready for review February 25, 2025 13:01
@jmchilton jmchilton mentioned this pull request Feb 25, 2025
2 tasks
@jmchilton
Copy link
Member Author

These test failures all seem unrelated.

@mvdbeek mvdbeek merged commit 2df4acb into galaxyproject:dev Mar 4, 2025
57 of 59 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Mar 4, 2025

Thank you @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants