Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show workflow help (and readme?) in run form #19736

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Mar 3, 2025

Builds on #19591 and #19294

Screen.Recording.2025-03-04.at.1.20.53.AM.mov

The screencast also shows the readme in the run form, but the only commit 1041e00 here includes just the change where we add the workflow.help to the workflow run model.

Alternatively, to show the readme in the run form as well i also added the help and readme properties to StoredWorkflowDetailed, and then simply used useWorkflowInstance to render the readme in WorkflowAnnotation. Please let me know if either of those are incorrect models to add these properties to.

On top of that, should we even show the readme in the run form in the first place; meaning only show help here?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan force-pushed the show_readme_in_run_form branch from 1041e00 to 103f9f8 Compare March 10, 2025 13:43
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review March 10, 2025 13:43
@github-actions github-actions bot added this to the 25.0 milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant