External noise curves and hitmaps #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyriac
changed the title
zonca
reviewed
Jul 28, 2020
mapsims/tests/test_noise_extern.py
Outdated
|
|
||
| # An example simple survey with external noise curves and hitsmaps. | ||
| class surveyFromExternalData: | ||
| def __init__(self,nbands,fwhms,noise_ell=None,noise_TT=None,noise_PP=None,noise_files=None,hitsmaps=None,hitsmap_filenames=None,ivar_maps=None,ivar_map_filenames=None,white_noises=None): |
mapsims/tests/test_noise_extern.py
Outdated
| nside = 16 | ||
| SONoiseSimulator = mapsims.noise.SONoiseSimulator(nside=nside) | ||
|
|
||
| ell, noise_ell_T, noise_ell_P = SONoiseSimulator._get_survey('LT3').get_noise_curves( |
There was a problem hiding this comment.
I think get_survey should not have an underscore, it seems pretty useful to use externally
mapsims/tests/test_noise_extern.py
Outdated
|
|
||
| # Test that this code and the SONoiseSimulator agree if the above used the same noise curves and hitsmap. | ||
| nside = 16 | ||
| SONoiseSimulator = mapsims.noise.SONoiseSimulator(nside=nside) |
There was a problem hiding this comment.
better call the object lowercase, like noise_sim
mapsims/tests/test_noise_extern.py
Outdated
| soNoiseSim = SONoiseSimulator.simulate('LT3',seed=1) | ||
|
|
||
|
|
||
| externSurvey = surveyFromExternalData(6,fwhms=[1.]*6,noise_ell=ell,noise_TT=noise_ell_T,noise_PP=noise_ell_P,hitsmaps=hitsMaps_all) |
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
Co-authored-by: Andrea Zonca <[email protected]>
|
this is good, thank you very much for working on this, CI is failing but is unrelated, I'll merge this and work on fixing that next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of the SONoiseSimulator class has been extended so that external noise curves and hitmaps can be used to simulate maps. This was done by slightly restructuring the noise.py module so that there is a shared base class, and SONoiseSimulator and ExternalNoiseSimulator derived classes. A test/ example file: tests/test_noise_extern.py is supplied to show how to use the code and to check that the ExternalNoiseSimulator and SONoiseSimulator produce the same output if using the same noise curves and hitmaps.
(Partially addresses #47 )