improvement(framework): allow users to specify proxy hostname in project config #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
add-proxy-config
branch
from
d17f332 to
56a70b2
Compare
eysi09
force-pushed
the
add-proxy-config
branch
from
56a70b2 to
5cbfa13
Compare
edvald
approved these changes
Feb 7, 2023
stefreak
reviewed
Feb 7, 2023
| @@ -319,6 +324,19 @@ export const projectDocsSchema = () => | |||
| ` | |||
| ) | |||
| .example([".gardenignore", ".gitignore"]), | |||
| proxy: joi.object().keys({ | |||
| hostname: joi | |||
There was a problem hiding this comment.
I think this could easily be confused with a proxy setting for garden itself; port-forwards: listen-address would be less confusing to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After upgrading to Node 18, some users reported issues with port forwarding to "localhost" when using Node's
createProxyMiddlewarepackage.This appears to be mostly the expected behaviour in Node 17+ and previously the only workaround was to set the proxy URL via the
GARDEN_DEFAULT_PROXY_ADDRESSenv var.This PR adds a
proxyfield to the project config so that user can explicitly set the proxy address for the project without having to ask everyone to update their environment variables:Which issue(s) this PR fixes:
Fixes #3667
Special notes for your reviewer: