Add microsecond support for ISO 8601 datetime formats #12511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me, @himynameistimli Worth adding a few tests? |
|
We are working on big changes to GraphQL in #11480. We plan to merge it next week. I wonder if you could either wait until next week and make a new PR against master or just make the PR for the schema refactor branch. Otherwise there will be merge conflicts that might result in this code getting lost. Thanks! |
|
Alright let me PR it against the schema refactor branch for now. |
DSchau
added
the
status: blocked
|
Closing this PR, see #12533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to use
formatStringto format dates in GraphQL, we get "Invalid date", which I believe is due to the precision format of seconds.From what I've seen in other issues/PRs, it seems to be related to the list of formats in type-date.js file. It seems to only have ISO formats with millisecond precision (
YYYY-MM-DDTHHmmss.SSS). We're using a python backend api for page generation and their default precision is in microseconds (YYYY-MM-DDTHHmmss.SSSSSS).(ref: https://docs.python.org/3.7/library/datetime.html)
The proposed fix is to add microseconds support for UTC and local time.
Related Issues
Related to #4813