-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTF-next: migrate using-contentful #31270
Closed
axe312ger
wants to merge
35
commits into
feat/contentful-schema-generation
from
refactor/contentful-migrate-using-contentful
Closed
CTF-next: migrate using-contentful #31270
axe312ger
wants to merge
35
commits into
feat/contentful-schema-generation
from
refactor/contentful-migrate-using-contentful
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
commented
May 5, 2021
@@ -86,13 +86,13 @@ export const pageQuery = graphql` | |||
} | |||
brand { | |||
companyName { | |||
companyName | |||
raw | |||
} | |||
} | |||
categories { | |||
id | |||
title { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails as references currently always use the ContentfulEntry
interface which includes all content types.
Will change the schema to detect reference type validation and use single-type/unions as types for these fields.
17 tasks
25 tasks
95366fc
to
4656166
Compare
61f846c
to
a5ddad2
Compare
849e5a3
to
05324da
Compare
4f7e213
to
3a03727
Compare
380d85b
to
c342248
Compare
5ce5b86
to
a5715aa
Compare
a5715aa
to
6086c52
Compare
This reverts commit 8d94396.
Also: * test: add unit tests for schema customization * fix: rich text inline rendering * test: update e2e test schema dump
ddc5f0a
to
6609fd2
Compare
17c46b2
to
c9ffbc6
Compare
351d89e
to
ef6b579
Compare
776a15e
to
bf32fae
Compare
c3fc6da
to
8aa8f20
Compare
8aa8f20
to
7ea4514
Compare
this is now included in #35113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this migrates using-contentful to the new generated schema