-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove reference resolve by Contentful SDK and clean up #34561
refactor: remove reference resolve by Contentful SDK and clean up #34561
Conversation
@@ -6,7 +6,6 @@ exports.contentTypeItems = () => [ | |||
type: `Link`, | |||
linkType: `Space`, | |||
id: `uzfinxahlog0`, | |||
contentful_id: `uzfinxahlog0`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is actually never returned by Contentful API.
} | ||
}, | ||
"id": "c7LAnCobuuWYSqks6wAwY2a", | ||
"id": "7LAnCobuuWYSqks6wAwY2a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the c
prefixing was long removed. This is some left-over in the snapshots
} | ||
"type": "Link", | ||
"linkType": "Asset", | ||
"id": "6m5AJ9vMPKc8OUoQeoCS4o" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't resolve twice anymore, therefore this is just a link instead of the whole node value
Next steps: The snapshot based tests are mind-buggling as usual. Switching to a more flat structure results in huge change sets in the snapshots. I'll have a look at this again soon and will check if I can split up the changes and restructure them. Happy weekend 🎉 |
c203a1b
to
d069d9b
Compare
This is WIP
The duplicated and bloated reference resolving logic blocks me from finishing #34549.
I want to explore if we can clean it up and release this before this big new major version of the plugin.