refactor: remove reference resolve by Contentful SDK and clean up #34561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
axe312ger
commented
Jan 21, 2022
| @@ -6,7 +6,6 @@ exports.contentTypeItems = () => [ | |||
| type: `Link`, | |||
| linkType: `Space`, | |||
| id: `uzfinxahlog0`, | |||
| contentful_id: `uzfinxahlog0`, | |||
There was a problem hiding this comment.
This value is actually never returned by Contentful API.
axe312ger
commented
Jan 21, 2022
| } | ||
| }, | ||
| "id": "c7LAnCobuuWYSqks6wAwY2a", | ||
| "id": "7LAnCobuuWYSqks6wAwY2a", |
There was a problem hiding this comment.
the c prefixing was long removed. This is some left-over in the snapshots
axe312ger
commented
Jan 21, 2022
| } | ||
| "type": "Link", | ||
| "linkType": "Asset", | ||
| "id": "6m5AJ9vMPKc8OUoQeoCS4o" |
There was a problem hiding this comment.
We don't resolve twice anymore, therefore this is just a link instead of the whole node value
|
Next steps: The snapshot based tests are mind-buggling as usual. Switching to a more flat structure results in huge change sets in the snapshots. I'll have a look at this again soon and will check if I can split up the changes and restructure them. Happy weekend 🎉 |
axe312ger
force-pushed
the
refactor/contentful-reference-resolving
branch
from
c203a1b to
d069d9b
Compare
axe312ger
changed the base branch from
master
to
refactor/contentful-clean-up-tests
LekoArts
removed
the
status: triage needed
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP
The duplicated and bloated reference resolving logic blocks me from finishing #34549.
I want to explore if we can clean it up and release this before this big new major version of the plugin.