Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean up and refactor Contentful unit tests #34584

Merged
merged 11 commits into from
Feb 1, 2022
Merged

test: clean up and refactor Contentful unit tests #34584

merged 11 commits into from
Feb 1, 2022

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Jan 25, 2022 •
edited
Loading

Some of the unit tests of gatsby-source-contentful rely on snapshots with thousands of lines of data.

These are insanely hard to maintain and cause a lot of headache. This PR removes all unmaintainable snapshots, replacing them with actual data testing code.

Tests

  • removed huge snapshots and reflected what they are supposed to check in actual test code
  • fixed a broken test which checked for assets instead of deleted entries
  • many tests no more depend on the order of the data
  • tests for normalize.js now can be run independent from each other

Snapshots & fixtures

  • adds the new meta tags (only empty here but was missing)
  • removes leftovers from prefixing id's with c
  • removes the extra contentful_id property which is not added anymore to the data
  • checks our reporter output via snapshots so we always see whats happening in the tests data fixtures

Other

  • content type items are no more created twice (mini-minimal performance win)

This will greatly accelerate the progression and review-ability of #31385

@axe312ger axe312ger added the topic: source-contentful Related to Gatsby's integration with Contentful label Jan 25, 2022
@axe312ger axe312ger changed the title test: update Contentful test fixtures test: clean up and refactor Contentful unit tests Jan 25, 2022
@axe312ger axe312ger requested a review from wardpeet January 25, 2022 15:35
wardpeet
wardpeet reviewed Jan 28, 2022
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

axe312ger and others added 6 commits January 28, 2022 05:37
@axe312ger
fix(gatsby-source-contentful): remove duplicate resolving (#34599)
6e955a4 
* perf: resolve all Contentful links manually

* perf(Contentful): no more cache previous Contentful API syncs

* feat(contentful): report new and update node counts seperate from each other
@axe312ger @wardpeet
docs: fix typo in comment
c6f2b7c 
Co-authored-by: Ward Peeters <[email protected]>
@axe312ger @wardpeet
refactor: simplify content type node creation logic
dabfb7d 
Co-authored-by: Ward Peeters <[email protected]>
@axe312ger
test: improve actions mocking and test for node creation, deletion an…
e17d9cc 
…d touching
@axe312ger
test: move logging test snapshots inline
719e93e
@axe312ger
refactor(test): only test log output of last and relevant run
c7466bf
@axe312ger axe312ger requested a review from wardpeet January 31, 2022 16:16
@wardpeet wardpeet merged commit 102eec0 into master Feb 1, 2022
@wardpeet wardpeet deleted the refactor/contentful-clean-up-tests branch February 1, 2022 13:18
@axe312ger axe312ger mentioned this pull request Feb 1, 2022
Merged
This was referenced Feb 16, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axe312ger @wardpeet