fix(gatsby-plugin-gatsby-cloud): don't add undefined to preload path if assetPrefix is falsy
#35400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h if assetPrefix is falsy
gatsbot
bot
added
the
status: triage needed
pieh
commented
Apr 11, 2022
| @@ -85,7 +85,7 @@ function linkHeaders(files, pathPrefix, assetPrefix) { | |||
| files[resourceType].forEach(file => { | |||
| linkHeaders.push( | |||
| linkTemplate( | |||
| `${assetPrefix && assetPrefix + `/`}${pathPrefix}/${file}`, | |||
| `${assetPrefix ? assetPrefix + `/` : ``}${pathPrefix}/${file}`, | |||
There was a problem hiding this comment.
This was producing undefined/foo/bar kind of results when assetPrefix was falsy
pieh
removed
the
status: triage needed
EzraEllette
approved these changes
Apr 11, 2022
This was referenced Nov 27, 2023
This was referenced Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Related Issues