Migrate to Qt6 #657
Draft
Migrate to Qt6 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Before this fix, if the value property has a binding instead of a value, any modification from the GUI (e.g. hitting the up arrow on the spin box) would not actually change the displayed value because it is immediately reset back to the value set by the binding. This is the case in the `GzPose` module and the effect can be easily be seen in the `GridConfig` plugin. To test, run: `gz gui -c examples/config/grid_config.config` You will see that, before this change, modifying the x,y,z,roll,pitch, yaw values actually changes the grid configuration, but the updated values are not displayed in the spinbox. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #586
Requires #656
Summary
Based on #596, but offers a simpler migration. Mainly, we keep using the plugin approach we were using before and set context properties to make the plugin's functionality available in QML modules. The plugin's name is prepended with an underscore (_) since properties that start with an uppercase letter are not allowed in Qt6. See https://doc.qt.io/qt-5/qtqml-syntax-objectattributes.html#defining-property-attributes
This PR also does not try to support both Qt5 and Qt6 as it's not clear right now if that will actually be possible. We can revisit this later if we need to.
Notes
QtQuick.DialogsQt5Compat.GraphicalEffectsQtCoreTODO:
FileDialogloses functionalityTest it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.