Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-rs #425

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Build-rs #425

merged 6 commits into from
Dec 22, 2021

Conversation

ChristianBeilschmidt
Copy link
Member

@ChristianBeilschmidt ChristianBeilschmidt commented Dec 20, 2021

I did the following things:

  1. Removed anyhow from our build-dependencies and just unwrapped the result in the build.rs file.
  2. Clippy wanted to add #[must_use] labels to functions that take &self and return Self. This makes sense since not using would mean you did something wrong.
  3. The arrow example was not working anymore 🤷. I changed the pointer cast. Fortunately, it seems that our in-code conversions still work.
  4. I updated tokio and could remove some Clippy lint exclusions (// TODO: remove when https://github.com/tokio-rs/tokio/issues/4245 is fixed).
  5. I updated Actix-web and they removed AnyBody. This means I had to wrap our error handler differently. You now have to put it into an EitherBody-enum and this takes a BoxBody. So I had to call boxed() here as well. Please check that the HTTP responses still work, for me, it looks fine.

@ChristianBeilschmidt
Copy link
Member Author

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1605587521

  • 19 of 21 (90.48%) changed or added relevant lines in 5 files are covered.
  • 52 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 85.377%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/src/pro/util/tests.rs 1 2 50.0%
services/src/util/tests.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
datatypes/src/raster/grid.rs 2 77.31%
operators/src/processing/meteosat/reflectance.rs 4 97.76%
operators/src/processing/meteosat/mod.rs 12 77.5%
operators/src/processing/meteosat/radiance.rs 17 86.74%
operators/src/processing/meteosat/temperature.rs 17 92.16%
Totals Coverage Status
Change from base Build 1601209590: 0.07%
Covered Lines: 27563
Relevant Lines: 32284

💛 - Coveralls

@jdroenner
Copy link
Member

bors merge

@bors bors bot merged commit 624e2a7 into master Dec 22, 2021
@jdroenner jdroenner deleted the build-rs branch December 22, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants