Remove option to scale grain size in lower mantle #5851
Merged
+20
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Jun 7, 2024
source/material_model/grain_size.cc
Outdated
| AssertThrow(pv_grain_size_scaling == 1.0, | ||
| ExcMessage("Error: The 'Lower mantle grain size scaling' parameter " | ||
| "has been removed. Please remove it from your input file. For models " | ||
| "with large sptial variations in grain size, please advect your " |
There was a problem hiding this comment.
Here and for the other message:
Suggested change
| "with large sptial variations in grain size, please advect your " | |
| "with large spatial variations in grain size, please advect your " |
|
Thank you! I've addressed your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was only useful because you would get large jumps in the grain size compositional field between upper and lower mantle, but now we can use particles instead.
For new features/models or changes of existing features: