Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ARM64 (aarch64-linux-gnu) Support #107

Merged
merged 9 commits into from
May 26, 2021
Merged

Initial ARM64 (aarch64-linux-gnu) Support #107

merged 9 commits into from
May 26, 2021

Conversation

jamesmcclain
Copy link
Member

@jamesmcclain jamesmcclain commented May 16, 2021

The aarch64-linux-gnu library is linked against GDAL 2.4 because that was was easily available in the Debian Buster package repository. The build generated here has not been tested, though a separate build on an ARM64 EC2 instance did pass all tests.

  • Test on Macintosh
  • Test on x86_64-linux-gnu
  • Test on aarch64-linux-gnu
  • Update README.md, &c.

Closes #106

@jamesmcclain jamesmcclain changed the title Initial ARM64 (aarch64-linux-gnu) Initial ARM64 (aarch64-linux-gnu) Support May 16, 2021
@jamesmcclain jamesmcclain force-pushed the aarch64 branch 4 times, most recently from e61f98e to 0c9254b Compare May 17, 2021 00:03
@jamesmcclain jamesmcclain requested a review from pomadchin May 17, 2021 00:22
@jamesmcclain
Copy link
Member Author

jamesmcclain commented May 17, 2021

@pomadchin Please test to see if the Macintosh version of these still works. The only change that should be visible from the perspective of the Macintosh code is that the file name of the shared library has changed, so I anticipate that it should work.

@jamesmcclain
Copy link
Member Author

jamesmcclain commented May 17, 2021

With the addition of a second architecture, #91 is beginning to look more appealing. That would also eliminate concerns such as those raised in #100 . (It should also be noted that on Linux at least, many of these concerns can be dissolve by just creating appropriately-named symbol links to GDAL shared libararies.)

BOOST_TEST(success == false);
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, there is GDAL 3.2 in unstable packages (see: https://packages.debian.org/search?keywords=gdal) would it be possible just to use GDAL 3.2?

@pomadchin
Copy link
Member

Works good on Mac 🟢 !

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything work nice and artifacts seem to be published correctly:

jar content

My only question is about GDAL 3.2 arm bindings, is it possible to use the unstable repo (still better in my opinion than the outdated GDAL 2.x)? Or there are some concerns related to that?

@jamesmcclain
Copy link
Member Author

jamesmcclain commented May 18, 2021

Everything work nice and artifacts seem to be published correctly:

jar content

Whoops, I think ...SNAPSHOT-3.jar is the one that needs to be tested (the ...SNAPSHOT.jar was created by an earlier version of that PR branch, sorry for not saying that earlier).

My only question is about GDAL 3.2 arm bindings, is it possible to use the unstable repo (still better in my opinion than the outdated GDAL 2.x)? Or there are some concerns related to that?

Yes, it is possible, but I (I think that I) remember ARM packages not being available for unstable when I was trying to put this together over the weekend (or something like that). In any case, I am considering just linking using -l:libgdal.so which would definitely (probably) fix this problem, but might be undesirable for other reasons.

@pomadchin
Copy link
Member

@jamesmcclain yea, that is the contents of the gdal-warp-bindings-1.1.2-aarch64-20210518.015727-3.jar looked through the sonatype viewer. I confirmed it manually as well though, all is good 💯

hmm according to https://packages.debian.org/sid/libgdal-dev it is here 👀

@jamesmcclain
Copy link
Member Author

@jamesmcclain yea, that is the contents of the gdal-warp-bindings-1.1.2-aarch64-20210518.015727-3.jar looked through the sonatype viewer. I confirmed it manually as well though, all is good

hmm according to https://packages.debian.org/sid/libgdal-dev it is here

👁️ 👁️

@jamesmcclain jamesmcclain merged commit 79d3b48 into master May 26, 2021
@jamesmcclain jamesmcclain deleted the aarch64 branch May 26, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate/create aarch64-linux-gnu Port
2 participants