-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDAL 3.9.x build #131
GDAL 3.9.x build #131
Conversation
fe38d99
to
44fe512
Compare
44fe512
to
8ba1488
Compare
4e1f5b9
to
e9719fb
Compare
"-of", "MEM", | ||
"-of", "VRT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has always been VRT; GDAL used the last appended -of VRT
to the param list. With MEM tests seem to be super slow btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I'm okay with this change, but my recollection is that these should write to in-memory structures which should be relatively fast.
6c52025
to
83e303a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes generally look good to me, pending the couple of questions that I asked. Exciting that this project is still being updated!
"-of", "MEM", | ||
"-of", "VRT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I'm okay with this change, but my recollection is that these should write to in-memory structures which should be relatively fast.
options_array[i++] = "-of"; | ||
options_array[i++] = "VRT"; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this also work with version of GDAL earlier than 3.9.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! < 3.9 GDAL was ignorant to duplicate args, and was using the last one passed. Now they have a more clear semantics of what args can be repeatable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
GT seems to be happy with this change: locationtech/geotrellis#3540 |
🎉 🎉 🎉 |
Merging it in and cutting a release! |
Build against GDAL 3.9.x; windows is still behind.