Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL 3.9.x build #131

Merged
merged 4 commits into from
May 19, 2024
Merged

GDAL 3.9.x build #131

merged 4 commits into from
May 19, 2024

Conversation

pomadchin
Copy link
Member

Build against GDAL 3.9.x; windows is still behind.

"-of", "MEM",
"-of", "VRT",
Copy link
Member Author

@pomadchin pomadchin May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has always been VRT; GDAL used the last appended -of VRT to the param list. With MEM tests seem to be super slow btw.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I'm okay with this change, but my recollection is that these should write to in-memory structures which should be relatively fast.

Copy link
Member

@jamesmcclain jamesmcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes generally look good to me, pending the couple of questions that I asked. Exciting that this project is still being updated!

"-of", "MEM",
"-of", "VRT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I'm okay with this change, but my recollection is that these should write to in-memory structures which should be relatively fast.

options_array[i++] = "-of";
options_array[i++] = "VRT";
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this also work with version of GDAL earlier than 3.9.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! < 3.9 GDAL was ignorant to duplicate args, and was using the last one passed. Now they have a more clear semantics of what args can be repeatable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pomadchin
Copy link
Member Author

GT seems to be happy with this change: locationtech/geotrellis#3540

@jamesmcclain
Copy link
Member

GT seems to be happy with this change: locationtech/geotrellis#3540

🎉 🎉 🎉

@pomadchin
Copy link
Member Author

Merging it in and cutting a release!

@pomadchin pomadchin merged commit 4446b21 into master May 19, 2024
5 checks passed
@pomadchin pomadchin deleted the update/gdal-3.9 branch May 19, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants