chore: fix gh ci for rpsec #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssa-wtag
force-pushed
the
Fix-GH-Pipeline-for-Rspec
branch
from
cf942c3 to
f17a682
Compare
ssa-wtag
force-pushed
the
Fix-GH-Pipeline-for-Rspec
branch
from
ac33156 to
e5c65af
Compare
ssa-wtag
commented
Nov 18, 2024
| if defined?(Rails) | ||
| @original_rails = Rails | ||
| Object.send(:remove_const, :Rails) | ||
| end |
There was a problem hiding this comment.
this change is not needed, since it was introduced in part of railtie spec.
|
Thanks for fixing it, @ssa-wtag 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally the spec passed, because we have Rails env there. But in a gem running in CI, this rails env is missing- that's why it was failing.