Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav 1.7 no longer accepts groupnames that are integers #2863

Closed
jgonyea opened this issue Mar 22, 2020 · 1 comment
Closed

Grav 1.7 no longer accepts groupnames that are integers #2863

jgonyea opened this issue Mar 22, 2020 · 1 comment
Assignees

Comments

@jgonyea
Copy link
Contributor

jgonyea commented Mar 22, 2020

I have a group.yaml file that is similar to this:

11796:
  groupname: '11796'
  readableName: Group-11796
  icon: users
  access:
    site: {  }
    admin: {  }

This throws the following error:

Argument 1 passed to Grav\Framework\Flex\Storage\SimpleStorage::getObjectMeta() must be of the type string, int given, called in /var/www/html/system/src/Grav/Framework/Flex/Storage/SimpleStorage.php on line 444

The type hinting is expecting a string, but since the group name is an integer, this fails.

I'm renaming my groups for now, but I wanted to bring it to your attention in the event this breaks other things.

@jgonyea
Copy link
Contributor Author

jgonyea commented Mar 22, 2020

To reproduce error:
Create a new group with the name "1234" and save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants