Star rating error after my update 7.4.3

[mrtngrsbch]

Hi,

I have upgraded to the latest version 7.4.3 and now I get an error when trying to save any page.

[mahagr]

Which plugin are you using for star ratings?

[mahagr]

7a1f553 should fix the issue.

[TheoAcker12]

This doesn't appear to be fully fixed. I didn't test all possible options, but with negative numbers, negative minimums, and high precision, number validation has issues. This is apparently because php's fmod function has issues (the code would be accurate if fmod were accurate).

An example failure is a value of -81.36802 with a minimum of -180 and step of .00001. Interestingly, a value of -81.26208 with the same parameters if perfectly fine, though if you up the step precision to .0000001 the situation reverses.

I'm going to use the previous code return !(isset($params['step']) && fmod($value - $min, $params['step']) === 0); for now, since that was working. Is there some issue with the previous code that required it to be changed?

[mrtngrsbch]

Which plugin are you using for star ratings?

sorry for my delay
I don't have any stars plugin

[mahagr]

Well, we do have integer check, let me try that one as fmod() seems to be broken beyond repair....

[mahagr]

@TheoAcker12 Now it should work!