Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<testing> Avoid validation on a YAML field, do not parse YAML #1480

Merged
merged 1 commit into from
May 17, 2017

Conversation

flaviocopes
Copy link
Contributor

YAML parsing causes a fatal error if the field is not a string

YAML parsing causes a fatal error if the field is not a string
@rhukster rhukster merged commit 8dabe88 into develop May 17, 2017
rhukster added a commit that referenced this pull request May 17, 2017
@flaviocopes flaviocopes deleted the feature/yaml-field-validation branch May 18, 2017 08:26
@8book
Copy link

8book commented Jan 29, 2018

This also happens in Gantry

I'm sorry to put this here, but I'm not very familiar with Github.
This tagged collection error still happens when we use the Gantry

@mahagr
Copy link
Member

mahagr commented Feb 1, 2018

@8book Where do you see this happening?

@8book
Copy link

8book commented Feb 1, 2018

Actually I was trying to use the same YAML I do with the other tags. And it was an error.

taxonomy:
author: exemplo

After testing a lot I found an example in the GRAV documentation that appeared something like below. And there it was!

items:
'@taxonomy.author': exemplo

But in the midst of so many tests I also discovered that this way when we switch to normal mode and save it gives error because the field "Items" in the Admin tries to rewrite and makes it go wrong.

I'm using Grav v1.3.10 - Admin v1.6.7
Gantry 5 Framework v5.4.22
Helium v5.4.22

@mahagr
Copy link
Member

mahagr commented Feb 1, 2018

To me it looks like your issue isn't the one in this issue and that you're trying to do something in a wrong way.

@8book
Copy link

8book commented Feb 1, 2018

It's exceedingly simple what I wanted to do just to make the author collection.
Either way works the second way, so an hour is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants