read all language files from theme stream #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you really want to load all themes? Wouldnt it make more sense to only load the base theme? |
I am only loading all themes in inheritance chain (so this will be usually two themes, if using inheritance)! What do you do if you want to create additional language variables in child theme? |
|
Alright, that makes sense to me. |
|
Looks good to me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when inheriting a theme and creating language files in the child theme, they will override the language files of the base theme. There is no chance to extend from the base theme language files other than copying them. This leads to a lot of manual syncing effort when updating the base theme.
I changed the language file loading to read language files from all themes in
theme://.This might be interesting for @lazybadger.