daterange - allow optionnal start date #3350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing dateRange filtering for collection, I encountered error when the start value is not specified (see #3345 for the issue).
After looking deeper in the source code, I found that the method dateRange() come from an interface and has three implementations and the fix I submited in the issue was not complete. That's why I submit this pull request.
I've divided the fix into three commit so you may discard some of them :
As 0, null and false have the same behaviour, the new version is retro-compatible with hypothetical legacy plugins that use the method.
The code have been manually tested on page collection with a fresh install of the fork and default theme :