Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System view: plugin license status separate column #6896

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025

Description

Summary of changes

  • Plugin license status now has its own column in the System view to actually display the LicenseStatus::$label string
    Screenshot 2025-01-18 at 11 11 35

  • LicenseStatus supports new link, dialog, drawer props

Docs

App::plugin(
  name: 'my/plugin',
  extends: [...],
  license: [
    'name' => 'Custom license',
    'link' => 'https://mylicenseshop.com',
    'status' => [
      'value' => 'missing',
      'theme' => 'purple',
      'label' => 'Get a license',
      'icon' => 'smile',
      'dialog' => 'my/dialog',
    ]
  ]
);

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

@distantnative distantnative force-pushed the v5/enhancement/plugin-license branch from 986b9ca to f215df8 Compare January 11, 2025 13:15
@bastianallgeier
Copy link
Member

  • I would keep the green status color for custom licenses and set the free licenses in a neutral color
  • What about "Unknown license" or "No license" in the license column and "unlicensed" in the status column?

@distantnative
Copy link
Member Author

distantnative commented Jan 18, 2025

@bastianallgeier

Screenshot 2025-01-18 at 11 11 35

I stuck to a more minimal solution now. Just changing the license status to only "Unkown" to signal that the status I unknown, not the license (well that too, but that's already expressed by the - in the other column).

And kept green for any license status that is valid. Free plugins are always valid.

@distantnative distantnative force-pushed the v5/enhancement/plugin-license branch from eb93004 to 954c07c Compare January 18, 2025 10:01
@distantnative distantnative marked this pull request as ready for review January 18, 2025 10:14
@distantnative distantnative requested review from a team January 18, 2025 10:14
@distantnative distantnative removed the needs: tests 🧪 Requires missing tests label Jan 18, 2025
@bastianallgeier
Copy link
Member

Is there a reason why you moved it to beta 3?

@distantnative
Copy link
Member Author

@bastianallgeier Wasn't sure if we'd get consensus until tomorrow and didn't want to put pressure on/rush it. So mostly marked those that I think are easy to review and decide for beta.2, bigger stuff for beta.3. But if it's ready, can go into beta.2 as well.

@distantnative distantnative merged commit fa013ca into v5/develop Jan 20, 2025
7 checks passed
@distantnative distantnative deleted the v5/enhancement/plugin-license branch January 20, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants