Page duplicate dialog: don't require toggles #6922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6921
Description
Summary of changes
Reasoning
required
toggles, in v5 one cannot submit the form without activating the toggle, so false is no option.required: true
actually has no effect. So I do like that one can actually require a toggle/checkbox to be set. We just have to remove the required option from use cases like here where it's not right.Changelog
Not from this PR, but so far missed...
Breaking changes
required: true
on checkbox and toggle fields now enforces that these fields need to be checked/toggles (active state)Ready?
Unit tests for fixed bug/featureFor review team