enhancement: add a single space after colon in headers in Response class #6976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a single space after the
:
in header responses for better server support.Summary of changes
Add a single space after colon in headers in Response class.
Before:
Content-Type:foo/bar
After:
Reasoning
That single space was expected in HTTP/1.0.
While since HTTP/1.1 it's optional, some products still seem to rely on it being present. So, adding it broadens the support for servers (and really old browsers I guess).
Additional context
HTTP/1.0: https://datatracker.ietf.org/doc/html/rfc1945#section-4.2
HTTP/1.1: https://datatracker.ietf.org/doc/html/rfc2616#section-4.2
Changelog
Fixes
Ready?
For review team