This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Issue 345 remove appengine support #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Including some GAE specific stuff
- The installer tasks have to be adapted yet
- Remove GAE options - Unroll all the zip files we used to have in the installer now that there are much less files involved
- Pull implementations up to their interfaces and migrate them to classes - Simplify code thanks to lambda runnables - Fix Spring bean definitions
dcbriccetti
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
N/A
Are there any risks to merging this code? If so, what are they?
Aggregate won't work on AppEngine any longer
Do we need any specific form for testing your changes? If so, please attach one
Nope.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Yes. I'll create issues before the release