This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Issue 359 filter metadata date marked as complete #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This makes the code more clear and easy to understand - It also allows us to reason better about those continue statements - Replace continues with breaks
- Also, make it sturdier by explicitly throwing when it receives an unexpected form element model type.
dcbriccetti
reviewed
Dec 28, 2018
src/main/java/org/opendatakit/aggregate/query/submission/QueryByUIFilterGroup.java
Outdated
Show resolved
Hide resolved
dcbriccetti
reviewed
Dec 28, 2018
src/main/java/org/opendatakit/aggregate/query/submission/QueryByUIFilterGroup.java
Show resolved
Hide resolved
dcbriccetti
approved these changes
Dec 28, 2018
ggalmazor
deleted the
issue_359_filter_metadata_date_marked_as_complete
branch
dcbriccetti
reviewed
Jan 2, 2019
| case INTEGER: | ||
| case DECIMAL: | ||
| case SELECT1: | ||
| case STRING: |
There was a problem hiding this comment.
Yup, you have an eye for this :) Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359, and #360
What has been done to verify that this works as intended?
Try to filter submissions by submission date or "date marked as complete" metadata fields and verify it works
Why is this the best possible solution? Were any other approaches considered?
This is the narrowest solution I could thin of.
Are there any risks to merging this code? If so, what are they?
Nope.
Do we need any specific form for testing your changes? If so, please attach one
No.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No.