This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Issue 373 Temporal filters after upgrading to v2.0 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They can lack their FormElementModel - They can be metadata fields - They can have a FormElementModel without child elements
ggalmazor
commented
Jan 11, 2019
| else | ||
| throw new IllegalArgumentException("Unrecognized dateTime field"); | ||
| super.addFilterChildren(fem, column.getChildColumnCode(), op, compareValue); |
There was a problem hiding this comment.
I've removed the exception because now I know more about this and I'm more confident about the range of scenarios we could get.
dcbriccetti
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373
What has been done to verify that this works as intended?
Manually tested following the instructions on #373.
Why is this the best possible solution? Were any other approaches considered?
This PR improves the detection of temporal fields of forms uploaded before upgrading to v2.0
Are there any risks to merging this code? If so, what are they?
Nope.
Do we need any specific form for testing your changes? If so, please attach one
Yes. The instructions to reproduce the scenario are attached to #373
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.