Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

Update AppEngine uploader app jar #444

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Update AppEngine uploader app jar #444

merged 1 commit into from
Mar 18, 2019

Conversation

ggalmazor
Copy link
Contributor

This PR updates the AppEngine Uploaded app JAR that the installer uses to deploy Aggregate to AppEngine.

The new uploader includes getodk/aggregate-components#5 to avoid problems due to the deprecation of the AppEngine Backends API by Google.

@ggalmazor ggalmazor requested a review from yanokwa March 17, 2019 14:35
@ggalmazor ggalmazor added the v1.x label Mar 17, 2019
@ggalmazor ggalmazor added this to the v1.7.2 milestone Mar 17, 2019
@yanokwa
Copy link
Member

yanokwa commented Mar 17, 2019

This PR itself is fine, but how were the changes in getodk/aggregate-components#5 verified? Specifically, can you confirm that

  1. The current installer doesn't work (as described at https://forum.opendatakit.org/t/18605) on a new GAE project.
  2. This installer does work on that project.

@ggalmazor
Copy link
Contributor Author

Sure!

  • I've verified that the official v1.7.1 won't complete the upload to AppEngine (complaining about the backends api)
  • I've verified that the new uploader works :)

I had to replace (again) the uploader jar. The PR is fine as far as I know :)

@yanokwa yanokwa merged commit 7d0d862 into getodk:v1_7 Mar 18, 2019
@yanokwa
Copy link
Member

yanokwa commented Mar 18, 2019

LGTM.

@yanokwa
Copy link
Member

yanokwa commented Mar 19, 2019

@ggalmazor How do you want to handle testing this?

@ggalmazor ggalmazor deleted the update_appengine_uploader_app_jar branch March 19, 2019 07:37
@kkrawczyk123
Copy link

I've checked: install generating, running and GAE installing process without any problems on Ubuntu.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@ggalmazor
Copy link
Contributor Author

Thanks! I think we can do a pint release v1.7.2 :)

@yanokwa
Copy link
Member

yanokwa commented Mar 21, 2019

Point release or pint release? 🍺

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants