Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

allow any 2XX status code from an external JSON server #470

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

terencehonles
Copy link
Contributor

Backports #469

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

Are there any risks to merging this code? If so, what are they?

Do we need any specific form for testing your changes? If so, please attach one

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggalmazor ggalmazor added this to the 1.7.4 milestone Jun 3, 2019
@lognaturel
Copy link
Member

lognaturel commented Nov 19, 2019

@ggalmazor @yanokwa is there a reason that this wasn't merged? It seems it should be in v1.7.4.

@ggalmazor ggalmazor merged commit 403fe0f into getodk:v1_7 Nov 19, 2019
@terencehonles terencehonles deleted the backport-allow-2xx-from-json-server branch December 5, 2019 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants