Skip to content
This repository was archived by the owner on Apr 16, 2022. It is now read-only.

Sorting activity in Details column. #331

Closed
kkrawczyk123 opened this issue Jan 30, 2018 · 8 comments · Fixed by #830
Closed

Sorting activity in Details column. #331

kkrawczyk123 opened this issue Jan 30, 2018 · 8 comments · Fixed by #830

Comments

@kkrawczyk123
Copy link
Contributor

kkrawczyk123 commented Jan 30, 2018

Software versions

Briefcase v1.9.beta, Java v1.8.x, operating system: Ubuntu, MacOs, Windows

Problem description

I was just wondering if sorting activity in Details column is needed at all?
There are also differences in behavior according to operating system:
-on Mac and Windows column has a clickable header with arrow but without any sorting activity
-on Ubuntu you can sort items which are present in table but no idea what is the subject of the order.

Issue update:
Expected behavior of sorting activity of columns headers:

Type of column Text on column up chevron ▲ down chevron ▼
Selection checkbox col Empty selected rows first selected rows last
Details button col Empty rows with status history first rows with status history last
Custom conf button bol Empty rows with custom conf first rows with custom conf last
Rest of columns Column name a-z sorting direction z-a sorting direction
@ggalmazor
Copy link
Contributor

We could disable sorting on columns with buttons in general. Or if we want to be able to sort, we could define the criteria to "has details" or "has custom conf", etc.

@ggalmazor
Copy link
Contributor

ggalmazor commented Feb 13, 2018

For this issue to be actionable, we should settle on what's expected. I propose the following:
Edited: The list is on my last comment.

@yanokwa, @lognaturel, any comments?

@yanokwa
Copy link
Member

yanokwa commented Feb 14, 2018

I like your proposal, @ggalmazor, but I do think it's nice to be sort by the columns with icons. For example, if you want to see which forms have custom configurations, a sort would be super useful.

I think the challenge is fitting header text, but in this case, I don't think header text is a must.

@ggalmazor
Copy link
Contributor

I'll try to keep track of the different suggestions...

Summary table:

Type of column Text on column up chevron ▲ down chevron ▼
Selection checkbox col Empty selected rows first selected rows last
Details button col Empty rows with status history first rows with status history last
Custom conf button bol Empty rows with custom conf first rows with custom conf last
Rest of columns Column name a-z sorting direction z-a sorting direction

@ggalmazor
Copy link
Contributor

@kkrawczyk123 Now that we have settled an expected behavior, could you add the table to the original issue description? This way we can tag this one as "contributor friendly"

This is the code for the table:

| Type of column | Text on column | up chevron ▲ | down chevron ▼ |
| --- | --- | --- | --- |
| Selection checkbox col | Empty |selected rows first | selected rows last |
| Details button col | Empty |rows with status history first | rows with status history last |
|Custom conf button bol | Empty |rows with custom conf first | rows with custom conf last |
| Rest of columns | Column name | a-z sorting direction | z-a sorting direction |

@jay4kelly
Copy link
Contributor

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @jay4kelly! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/briefcase/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

jay4kelly added a commit to jay4kelly/briefcase that referenced this issue Nov 14, 2019
@getodk-bot
Copy link
Member

getodk-bot commented Dec 1, 2019

Hello @jay4kelly, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants