This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Issue 796 support custom functions #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, @joeflack4! I deleted your comment by mistake :( I've reworked the PR to take advantage to a new feature of JavaRosa v1.16.0 and I was cleaning my own comments with my brain shut off and I deleted yours too :( :( |
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
|
@ggalmazor NP. Thanks for the work! |
lognaturel
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796
Use this form to test the PR: custom-function-form.txt
What has been done to verify that this works as intended?
Added an automated regression test
Why is this the best possible solution? Were any other approaches considered?
A brute force approach that used actual exception messages was considered to provide a quick&dirty solution that didn't require changes in JR, but we ultimately thought it was better to add a method in JR to provide fallback function handlers that would prevent the error from #796.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should be a narrow change that only prevents the issue from #796
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No.