Skip to content
This repository was archived by the owner on Apr 16, 2022. It is now read-only.

fix: added toString for CentralErrorMessage #822

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

florian42
Copy link
Contributor

Closes: #821

All tests were executed succesfully.

@codecov-io
Copy link

Codecov Report

Merging #822 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     48.63%   48.63%   -0.01%     
+ Complexity     1643     1642       -1     
============================================
  Files           192      192              
  Lines         10319    10320       +1     
  Branches        743      743              
============================================
  Hits           5019     5019              
- Misses         4942     4943       +1     
  Partials        358      358
Impacted Files Coverage Δ Complexity Δ
...it/briefcase/push/central/CentralErrorMessage.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/opendatakit/briefcase/ui/export/ExportPanel.java 48.07% <0%> (ø) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cc413...083d9fe. Read the comment docs.

Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks, @florian42!

@ggalmazor
Copy link
Contributor

ggalmazor commented Oct 2, 2019

So, some tips for testing this copied from the issue:

  • Unzip this form into Briefcase's storage directory. (Wrong ZIP)
  • Unzip Simple Form.zip into Briefcase's storage directory.
  • (Re)Start Briefcase
  • Push the form to a Central server

@kkrawczyk123
Copy link
Contributor

Finally tested with success!
Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@ggalmazor
Copy link
Contributor

Thank you for your patience, @kkrawczyk123 ;)

@ggalmazor ggalmazor merged commit 584f792 into getodk:master Oct 22, 2019
@ggalmazor ggalmazor added this to the v1.17.1 milestone Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error details in Central non-success HTTP response log entries
5 participants