This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #844
What has been done to verify that this works as intended?
Two things:
Manually pulled some forms in a Windows 10 box and verified that the paths in the
metadata.json
files contain/
dir separators (instead of the standard\
for Windows)Also verified that Briefcase can read these paths and work in Windows 10 too.
Added new automated tests to verify we will never include
/
, or\
in form directory names.\
would be valid in *nix filenames, but then we would have portability issues in Windows.Why is this the best possible solution? Were any other approaches considered?
This PR felt like it fell kinda short in two ways:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The most risky assumption is that, according to official Java docs,
/
dir separators should work both in Windows and *nix platforms. Other than that, changes in this PR feel pretty much safe.Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.