Return Problem if duplicate value contains )

[matthew-white]

Usually, if a database statement violates a uniqueness constraint, a 409.3 Problem is returned. However, if the duplicate value contains the character ), then a 500 error seems to be returned. This can be seen in this Sentry error. There, a form with a duplicate xmlFormId is uploaded, and the form ID contains ). I think the issue is that the ) causes the regular expression not to match:

central-backend/lib/util/db.js

Lines 338 to 348 in 192557a

	} else if (error.code === '23505') { // unique_violation
	const match = /^Key \(([^)]+)\)=\(([^)]+)\) already exists.$/.exec(error.detail);
	if (match != null) {
	const [ , rawFields, rawValues ] = match;
	return reject(Problem.user.uniquenessViolation({
	fields: splitPostgresTuple(rawFields).map(dequote),
	values: splitPostgresTuple(rawValues),
	table: error.table
	}));
	}
	} else if (error.code === '23503') { // foreign_key_violation

The error message in this case looks like this:

Key ("projectId", "xmlFormId")=(3, my_form (1)) already exists.

The xmlFormId contains a space and parentheses, but the Postgres error message didn't enclose the value in quotes or escape those characters.