Prevent Forms from introducing dataset name case conflicts #1127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#627
Prevents Forms and Dataset API from introducing published datasets with conflicting names, specifically the same name with different capitalization.
What has been done to verify that this works as intended?
Tests, trying with frontend.
Why is this the best possible solution? Were any other approaches considered?
I basically added another database query for a similarly named dataset. In the same area of code, we're also querying for an existing exactly matching dataset so we can reuse its ID and Actee ID for various things. I wasn't comfortable trying to combine these queries at this time, given the complicated logic of draft datasets, similar but not exact matches, multiple similar draft datasets, etc.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
This could potentially be added to the API docs. (#1096)
Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes