Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #473: always check auth if invalidate is true #474

Merged
merged 4 commits into from
May 2, 2022

Conversation

sadiqkhoja
Copy link
Contributor

Fixes #473:

  • Return 403 if invalidate is true and account doesn't exist
  • Added integration test to verify it

Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I left just a couple of small comments about testing.

Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks again, @sadiqkhoja! 🎉 I'll go ahead and merge now.

By the way, I'd love to learn more about what sort of issues you're interested in. Are you also interested in the frontend (Vue/HTML/CSS), or are you most interested in the backend (Node/database/API)? Do you also have an interest in ops or things related to Docker? Just wanted to hear more about what's interesting to you!

@matthew-white matthew-white merged commit d71a438 into getodk:master May 2, 2022
@sadiqkhoja
Copy link
Contributor Author

Thanks @matthew-white I am open to anything, if you have top 5 priority issues, please share I'll take them on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset: always check auth if ?invalidate=true
2 participants