improve: add ability to configure maximumPoolSize. #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktuite
approved these changes
May 6, 2022
|
For posterity: we decided to keep the default at 10 for now because we bumped it to 25 on a server with 4gb of RAM and started seeing many more premature close errors. It's not entirely clear that the errors were related to the pool size change and it's particularly weird that they continued once the value was changed back to 10. But we didn't have more time to spend on this immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure
maximumPoolSizefor Slonik. See #476 for more on why it could be useful to change the pool size. We originally planned to setmaximumPoolSizeto a constant, but ultimately decided to make it configurable. With this PR, the user can specifymaximumPoolSizein their database config; it defaults to 10. We use the database config to connect to both Slonik and Knex, but we only need to usemaximumPoolSizewith Slonik: Knex has its own approach to pooling. That means that part of the work of this PR is forwardingmaximumPoolSizeon to Slonik but not Knex.