Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #391: Ability to filter subtable by submission fields #924

Merged

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Jul 13, 2023

Closes #391

What has been done to verify that this works as intended?

Integration tests

Why is this the best possible solution? Were any other approaches considered?

Alternatives are mentioned in the issue

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None

Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.

Updated

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@sadiqkhoja sadiqkhoja marked this pull request as ready for review July 14, 2023 15:54
@sadiqkhoja sadiqkhoja requested a review from ktuite July 14, 2023 15:55
Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some familiarity with our OData setup, so I thought I could review. Looks great! It's nice that it didn't have to be a huge change.

@matthew-white matthew-white removed the request for review from ktuite July 14, 2023 18:03
@sadiqkhoja sadiqkhoja merged commit 2e96b9d into getodk:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to filter OData subtables
2 participants