Enhance: add entity version number and modify update entity API to work with version #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like this PR closes #832. Does that sound right? |
ktuite
reviewed
Aug 21, 2023
sadiqkhoja
force-pushed
the
features/entities/entity-version
branch
from
721f8ee to
8c5c79e
Compare
ktuite
approved these changes
Aug 26, 2023
test/integration/api/entities.js
Outdated
| })); | ||
|
|
||
| it('should reject if version does not match', testEntities(async (service) => { | ||
| // TODO: change logic around force flag and enforcing certain kinds of updates |
There was a problem hiding this comment.
can remove this and above TODO comment now?
ktuite
reviewed
Aug 29, 2023
| @@ -1317,7 +1317,7 @@ describe('datasets and entities', () => { | |||
| .then(({ headers, text }) => { | |||
| headers['content-disposition'].should.equal('attachment; filename="goodone.csv"; filename*=UTF-8\'\'goodone.csv'); | |||
| headers['content-type'].should.equal('text/csv; charset=utf-8'); | |||
| text.should.equal('name,label,first_name,age\n12345678-1234-4123-8234-123456789abc,Alice (88),Alice,88\n'); | |||
| text.should.equal('name,label,version,first_name,age\n12345678-1234-4123-8234-123456789abc,Alice (88),1,Alice,88\n'); | |||
There was a problem hiding this comment.
One thing I noticed when trying to make a form that looked up the version, and based on what we're talking about in the team meeting on Aug 29, name and label have to be what they are, but should version be __version?
There was a problem hiding this comment.
I like version for the attachment csv
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
forms/attachment/dataset.csvalso returns version numberWhat has been done to verify that this works as intended?
Integration tests and manual testing with frontend
Why is this the best possible solution? Were any other approaches considered?
Other option was to add version in query parameter or body, but version in ETag and If-Match is a cleaner approach
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
Will do it in a separate PR
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes