Improve appearance of <select> elements in Safari #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Oct 22, 2021
Comment on lines
+421
to
+425
| appearance: none; | ||
| appearance: auto; |
There was a problem hiding this comment.
We have autoprefixing set up, so the -webkit- property will also be specified.
The goal is to specify -webkit-appearance: none; for Safari while still specifying appearance: auto; for Chrome and Firefox. One challenge is that Chrome and Firefox both pay attention to -webkit-appearance. Safari doesn't support auto, so it will ignore the second appearance and end up with none.
We could also specify appearance: none; for all browsers. That would have the effect of removing the chevron that's shown to the right of the select element in Chrome and Firefox (those browsers add the chevron).
Comment on lines
-1750
to
-1751
| -webkit-appearance: none; | ||
| -moz-appearance: none; |
There was a problem hiding this comment.
We have autoprefixing set up, so these properties don't need to be specified.
The goal is to specify `-webkit-appearance: none;` for Safari while still specifying `appearance: auto;` for Chrome and Firefox. Also removing some unneeded prefixed appearance properties from Bootstrap CSS.
matthew-white
force-pushed
the
select-appearance-safari
branch
from
01459d5 to
9efbed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
selectelements look different in Safari than other browsers. Even within Safari,selectelements look different frominputelements. Right now in Safari, aselectelement looks like this:In Chrome, it looks like:
Firefox:
After this change, Chrome and Firefox will look like the same as now, but Safari will look like this: