Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run server if database migrations fail #258

Closed
matthew-white opened this issue Nov 11, 2021 · 0 comments · Fixed by #276
Closed

Don't run server if database migrations fail #258

matthew-white opened this issue Nov 11, 2021 · 0 comments · Fixed by #276

Comments

@matthew-white
Copy link
Member

matthew-white commented Nov 11, 2021

Right now if database migrations fail, start-odk.sh will still run the server. However, I think we want start-odk.sh to end immediately if database migrations fail and to not run the server. Otherwise you would have a server whose code doesn't match the database. In that case, many requests would result in a database error, and even if a request seems to succeed, it'd be harder to reason about the resulting state of the database.

For similar reasons, I think we also shouldn't run cron if migrations fail (also in start-odk.sh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant